chore: comprehensive refactor — async DB, dependency bumps, chat sync events, and code quality #10

alisson · 2026-04-23T22:35:51-03:00

alisson commented

2026-04-23 22:35:51 -03:00

Summary

This PR contains a broad set of maintenance and feature improvements across the codebase, primarily focused on async safety, dependency updates, internationalization completeness, and preparing for live chat property updates from the WhatsApp sync stream.

Changes

Async & Threading

Offloaded all database operations to relm4::spawn to prevent blocking the GTK main thread (application.rs, store/database.rs).
Moved QR code generation into relm4::spawn_blocking (utils.rs).
Added spawn_blocking wrapper for libsql database connection setup.

Dependencies

Bumped libadwaita to 0.9 and relm4 to 0.11.
Switched whatsapp-rust from a git dependency to the crates.io registry.
Updated Cargo.lock accordingly.

WhatsApp Session & Sync

Added handling for SelfPushNameUpdated during initial sync (session/client.rs, application.rs).
Added infrastructure to handle chat property updates and sync events (session/client.rs, application.rs, components/chat_list.rs).

Code Quality & Refactors

Reordered struct fields across ChatRow, ChatRowWidgets, Login, Message, and Application to follow the "length-then-alphabetical" convention.
Boxed large enum variants in session/client.rs and components/chat_view.rs to reduce stack size.
Added i18n! translations to previously hardcoded error strings and the about dialog.
Fixed i18n_f! macro to use replacen for correct placeholder substitution.
Cleaned up import ordering and removed redundant fully-qualified names.

Documentation

Added AGENTS.md with comprehensive AI agent guidelines for project development.

Chores

Added a FIXME note for the currently unused PKGDATADIR constant in config.rs.in.

### Summary This PR contains a broad set of maintenance and feature improvements across the codebase, primarily focused on async safety, dependency updates, internationalization completeness, and preparing for live chat property updates from the WhatsApp sync stream. ### Changes **Async & Threading** - Offloaded all database operations to `relm4::spawn` to prevent blocking the GTK main thread (`application.rs`, `store/database.rs`). - Moved QR code generation into `relm4::spawn_blocking` (`utils.rs`). - Added `spawn_blocking` wrapper for libsql database connection setup. **Dependencies** - Bumped `libadwaita` to `0.9` and `relm4` to `0.11`. - Switched `whatsapp-rust` from a git dependency to the crates.io registry. - Updated `Cargo.lock` accordingly. **WhatsApp Session & Sync** - Added handling for `SelfPushNameUpdated` during initial sync (`session/client.rs`, `application.rs`). - Added infrastructure to handle chat property updates and sync events (`session/client.rs`, `application.rs`, `components/chat_list.rs`). **Code Quality & Refactors** - Reordered struct fields across `ChatRow`, `ChatRowWidgets`, `Login`, `Message`, and `Application` to follow the "length-then-alphabetical" convention. - Boxed large enum variants in `session/client.rs` and `components/chat_view.rs` to reduce stack size. - Added `i18n!` translations to previously hardcoded error strings and the about dialog. - Fixed `i18n_f!` macro to use `replacen` for correct placeholder substitution. - Cleaned up import ordering and removed redundant fully-qualified names. **Documentation** - Added `AGENTS.md` with comprehensive AI agent guidelines for project development. **Chores** - Added a `FIXME` note for the currently unused `PKGDATADIR` constant in `config.rs.in`.

alisson added 15 commits

2026-04-23 22:35:51 -03:00

docs: add comprehensive AI agent guidelines for project development d740fa78db

chore(deps): bump libadwaita to 0.9, relm4 to 0.11, and switch whatsapp-rust to registry 7ff7258837

fix(i18n): update i18n_f macro to use replacen and translate app name c97e67f556

fix(i18n): translate hardcoded strings in about dialog dfe4ac33f4

chore(config): add FIXME note for unused PKGDATADIR constant 56ade1f282

refactor(app): offload async database operations to relm4::spawn and reorder fields 7ee56467ad

refactor(chat_list): reorder ChatRow and ChatRowWidgets fields cc86f5afcb

refactor(chat_view): use Box for large message variant, fix integer casts, and reorder fields 45dadfe9a6

refactor(login): reorder Login struct fields 3d4af26f49

refactor(session): use Box for large variants, add i18n to errors, and clean up imports 347d98f79a

refactor(state): reorder Message struct fields 8dec49caf8

fix(store): use spawn_blocking for database connection 41ce3cb843

fix(utils): offload QR code generation to spawn_blocking b9c985cf28

feat(session, application, chat_list): handle chat property updates and sync events 37614a6589

- Add ChatPropertyUpdate messages for pin, mute, and archive events
- Process HistorySync events to extract conversations and messages
- Handle OfflineSyncCompleted to transition app state from syncing to ready
- Add HistorySyncCompleted and OfflineSyncCompleted signals
- Add RemoveChat input to ChatList for archived chats
- Fallback to extended_text_message text when conversation is empty
- Add ProcessHistorySync command for blocking protobuf parsing

fix(session, application): handle SelfPushNameUpdated event during sync 2bb65731a7

alisson force-pushed refactor/updates from 2bb65731a7 to 59acd71526

2026-04-23 23:01:24 -03:00

Compare

alisson added 1 commit

2026-04-23 23:07:10 -03:00

build: downgrade target to GNOME 49 and libadwaita 1.8 4844bad8b0

- Switch libadwaita feature from v1_9 to v1_8 in Cargo.toml
- Switch relm4 feature from gnome_50 to gnome_49 in Cargo.toml
- Update AGENTS.md to reflect Relm4 0.11 and GNOME 49

alisson added 1 commit

2026-04-23 23:20:13 -03:00

chore: fix clippy warning a9626cbf9d

andrielfr requested review from andrielfr

2026-04-23 23:42:59 -03:00

alisson was assigned by andrielfr

2026-04-23 23:43:28 -03:00

andrielfr approved these changes

2026-04-23 23:43:49 -03:00

alisson force-pushed refactor/updates from ed55d3f71f to 6100766821

2026-07-04 19:34:24 -03:00

Compare

alisson force-pushed refactor/updates from 6100766821 to 965ace3e89

2026-07-04 19:54:05 -03:00

Compare

alisson added 1 commit

2026-07-04 20:26:19 -03:00

fix(session): clear credentials on logout to prevent infinite reconnect loop 3ded04af46

On Event::LoggedOut, the app was restarting the client with the same
stale credentials in whatsapp.db, causing an immediate LoggedOut event
and an infinite loop. Now:

- ClientCommand::LoggedOut disconnects and deletes whatsapp.db files
- ClientCommand::Restart also clears credentials before fresh start
- AppMsg::LoggedOut sends ClientInput::Start instead of ResetSession
- ClientCommand::Disconnected guards against stale events overwriting
  active connection states

andrielfr reviewed

2026-07-04 20:37:02 -03:00

src/session/client.rs

					
				@ -256,0 +281,4 @@

				    for path in [

				        db_path.as_path(),

				        std::path::Path::new(&wal_path),

import Path and use it

import `Path` and use it

alisson marked this conversation as resolved

andrielfr reviewed

2026-07-04 20:37:53 -03:00

src/session/client.rs

					
				@ -256,0 +285,4 @@

				        std::path::Path::new(&shm_path),

				    ] {

				        if path.exists()

				            && let Err(e) = std::fs::remove_file(path)

maybe it's ok to import std::fs too

maybe it's ok to import `std::fs` too

alisson marked this conversation as resolved

alisson added 1 commit

2026-07-04 20:46:14 -03:00

fix(store): resolve FK and UNIQUE constraint failures during initial sync e153c63636

Messages synced from history sync arrived before their chats were
saved to the database, causing FOREIGN KEY constraint failures.
Duplicate server_id insertions also failed because save_message only
handled ON CONFLICT(local_id), but synced messages use random UUIDs
for local_id.

- Add Database::ensure_chat_exists (INSERT OR IGNORE INTO chats)
- Add Database::save_synced_message (INSERT OR IGNORE on both PKs)
- Add ChatMessage::save_or_ignore delegating to save_synced_message
- Remove early return in MessagesSynced handler that dropped messages
  for chats not yet in memory (they may arrive before ChatSynced)
- Use save_or_ignore in ProcessMessagesSync instead of save

alisson added 1 commit

2026-07-04 22:56:10 -03:00

fix(chat_list, store): hide chats with no messages and fix empty server_id collisions 62caad7de9

- Skip adding chats to the list when they have no messages (chat_list.rs)
- Use NULLIF for empty server_id in save_synced_message to avoid UNIQUE
  constraint collisions across messages with no server ID
- Add detailed sync logging with duplicate/skip counts for diagnostics

alisson added 1 commit

2026-07-04 23:02:11 -03:00

chore: address review comments 1b7118e912